Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a custom logs panel instead of using the builtin Grafana logs panel, giving us total control over the it. The builtin Grafana panel does a lot for you, but provides no customization if you want to do things differently (even minor things like custom styling seem to be impossible). With this custom rewrite we've already been able to reduce several pain points and difficulties we ran into going the builtin route.
Though this is only the first pass, it contains all the necessary functionality to be usable, including:
And while it's not necessary functionality, we were able to also virtualize the logs panel (although there is a bug in it, see #45)
That said, there are some features missing from this that we'll be adding in later. Things like:
Demo
Due to this rewrite being so extensive, it's difficult to demo all the functionality in a succinct way. It's recommended you pull this and try it out for yourself.
Performance
There was a decent performance boost from this rewrite. We've reduced the number of DOM elements by over half (previous was ~25k elements, current is ~11.5k elements) and have improved our Lighthouse Score (an imperfect metric, but a readily available one). I've attached the old and new Lighthouse Score below:
Old:
New:
Resolves #36
Requirements (place an
x
in each[ ]
)